Add the baseEvent field to the Block header extension #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
fmacleal
approved these changes
Oct 10, 2025
Contributor
fmacleal
left a comment
fmacleal
left a comment
There was a problem hiding this comment.
Nice and important addition, good job! 🙂
I have added a few suggestions with some small typos and simple changes in the text. But it doesn't prevent the approval.
|
|
||
| ## Motivation | ||
|
|
||
| [RSKIP 194](./RSKIP194) proposes a modification in the block header to allow extending the block header without interfering with thew PowHSMs. |
Contributor
There was a problem hiding this comment.
suggestion:
Typo error.
Suggested change
| [RSKIP 194](./RSKIP194) proposes a modification in the block header to allow extending the block header without interfering with thew PowHSMs. | |
| [RSKIP 194](./RSKIP194) proposes a modification in the block header to allow extending the block header without interfering with the PowHSMs. |
|
|
||
| [RSKIP 351](./RSKIP351) indicates how this field is appended to the extensioin data. | ||
|
|
||
| This RSKIP add one additional field `baseEvent` to the block header extension , and also redefines the version number such that both `txExecutionSublistsEdges` and `baseEvent` fields can be included. |
Contributor
There was a problem hiding this comment.
suggestion:
Just adding the version number explicitly here.
Suggested change
| This RSKIP add one additional field `baseEvent` to the block header extension , and also redefines the version number such that both `txExecutionSublistsEdges` and `baseEvent` fields can be included. | |
| This RSKIP add one additional field `baseEvent` to the block header extension , and also redefines the version number to 2 such that both `txExecutionSublistsEdges` and `baseEvent` fields can be included. |
|
|
||
| If parallel transaction is not activated, then the value `txExecutionSublistsEdges` is left empty. | ||
|
|
||
| This RSKIP does not specify how the content of `baseEvent` is selected by the miners, not how the content is verified by the consensus code (these tules will be specified in a separate RSKIP). |
Contributor
There was a problem hiding this comment.
suggestion:
Typo in (these tules will be specified in a separate RSKIP)? Should it be rules instead of tules?
|
|
||
| RSKIP 144 and RSKIP351 defines how new fields are added using an header extension and how the block header is serialized. RSKIP351 also adds a new field to help parallel transaction processing. This RSKIP adds another field to the header extension and defines a new version number higher than the previous one. | ||
|
|
||
| Alternatively, we could use a bitmap for the version field, so that each bit specifies the presence (or absence) of each conditional field in the block header extension. However, this complicates consensus code when parsing the header as allows all field subsets to exist. If no parallel transaction processing is activated, leaving the field `txExecutionSublistsEdges` empty and additing a new element to the RLP list is simpler. |
Contributor
There was a problem hiding this comment.
suggestion:
Typo in additing.
Suggested change
| Alternatively, we could use a bitmap for the version field, so that each bit specifies the presence (or absence) of each conditional field in the block header extension. However, this complicates consensus code when parsing the header as allows all field subsets to exist. If no parallel transaction processing is activated, leaving the field `txExecutionSublistsEdges` empty and additing a new element to the RLP list is simpler. | |
| Alternatively, we could use a bitmap for the version field, so that each bit specifies the presence (or absence) of each conditional field in the block header extension. However, this complicates consensus code when parsing the header as allows all field subsets to exist. If no parallel transaction processing is activated, leaving the field `txExecutionSublistsEdges` empty and adding a new element to the RLP list is simpler. |
|
|
||
| [RSKIP 144](./RSKIP144) adds a new field to the header called `txExecutionSublistsEdges`. | ||
|
|
||
| [RSKIP 351](./RSKIP351) indicates how this field is appended to the extensioin data. |
Contributor
There was a problem hiding this comment.
suggestion:
Typo in extensioin.
Suggested change
| [RSKIP 351](./RSKIP351) indicates how this field is appended to the extensioin data. | |
| [RSKIP 351](./RSKIP351) indicates how this field is appended to the extension data. |
| | 516 |[Precompiled contracts for +/* on Secp256k1](IPs/RSKIP516.md)| 10-APR-2025 | SDL | Usa | Core | 2 | Adopted | | ||
| | 517 |[Block time-centric difficulty adjustment with uncle threshold](IPs/RSKIP517.md)| 29-MAY-2025 | PDG | Sec,Sca | Core | 1 | Draft | | ||
| | 518 |[Network Upgrade: Reed](IPs/RSKIP518.md)| 13-JUN-2025 | AE | Usa, Sca | Core | 3 | Adopted | | ||
| | 535 |[Add the baseEvent field to the Block header extension](IPs/RSKIP535.md)| 08-OCT-2025 | SDL | Sca | Core | 1 | Draft | |
Contributor
There was a problem hiding this comment.
suggestion:
Just to highlight the name of the field.
Suggested change
| | 535 |[Add the baseEvent field to the Block header extension](IPs/RSKIP535.md)| 08-OCT-2025 | SDL | Sca | Core | 1 | Draft | | |
| | 535 |[Add the `baseEvent` field to the Block header extension](IPs/RSKIP535.md)| 08-OCT-2025 | SDL | Sca | Core | 1 | Draft | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.